search

ruby-amqp / bunny

Bunny is a popular, easy to use, mature Ruby client for RabbitMQ
Other
1.39k stars 303 forks source link

Gem includes test certificates #612

Closed chaitrahegde115 closed 3 years ago

chaitrahegde115 commented 3 years ago

Hi, I have installed bunny-2.14.4 gem in td-agent. This gem has installed default certificates in spec/tls folder. So I wanted to know what is the use of these certificates and are these certificates really used in the runtime? Also, if the certificates are not used at the runtime can these certificates be deleted while bundling the gem so that the default certificates are not bundled with bunny gem? Having default certificates bundled in a gem is a security risk.

michaelklishin commented 3 years ago

They are used by the test suite unless you override their location. They can be excluded. However, test files are included by default by RubyGems, so I am not sure if excluding tests is a common practice in the community.

michaelklishin commented 3 years ago

spec/tls/* and all files not under lib and spec have been excluded from the gem. I'll cut a new release after taking a look at one more issue.

michaelklishin commented 3 years ago

2.18.0 is out.