search

ruby-amqp / bunny

Bunny is a popular, easy to use, mature Ruby client for RabbitMQ
Other
1.39k stars 303 forks source link

Fix documentation and typos #679

Closed asms closed 8 months ago

asms commented 8 months ago

Update reset_recovery_attempts_after_reconnection to be documented as a Boolean type, and fix various typos of the word "heartbeat" that appear as "hearbeat".

michaelklishin commented 8 months ago

A doc change cannot affect code behavior or tests, so you don't have to worry about it unless you want to learn how Bunny test suites are run, for instance, if you have plans to contribute a code change.

I'm not sure why would anyone use a float for this value. Integers (fixnums) are accepted just like any other numerical type.

So thank you for taking the time to contribute but I think this is a solution in search of a problem :)