search

ruby-amqp / hutch

A system for processing messages from RabbitMQ.
https://gocardless.com/blog/hutch-inter-service-communication-with-rabbitmq/
MIT License
857 stars 137 forks source link

fix Sentry integration - make sure that the payload is a hash, not JSON #386

Closed Azdaroth closed 2 years ago

Azdaroth commented 2 years ago

I've just discovered in one of the projects that errors are not getting delivered to Sentry and in the logs I found something coming from lib/sentry/utils/argument_checking_helper: ArgumentError: expect the argument to be a Hash, got String

Looks like the setup was not done correctly in the spec and configure_scope method was returning early, without the evaluation of the block (https://github.com/getsentry/sentry-ruby/blob/c9b4eac913f0c6510178c451da57d91fc340fa20/sentry-ruby/lib/sentry-ruby.rb#L163). And because of that, the spec didn't catch the error related to the expected type of payload which must be a hash, not a JSON. This patch fixes it.

Azdaroth commented 2 years ago

Hmm, not sure why the suite is failung under JRuby, looks unrelated :/

michaelklishin commented 2 years ago

Yes, the JRuby failures are not related or new.