Closed ahmedsaalah closed 1 year ago
Should this new ivar be reset at some point?
https://github.com/ruby-amqp/hutch/blob/87adff64c8c43fa4ec15b258b851d81d12968e15/lib/hutch/worker.rb#L72 In worker.rb handle_message method, every message consumer_instance instantiated so no need to be reset at all
Should this new ivar be reset at some point?
@michaelklishin Please let me know if you have any other concerns
@michaelklishin Updated .Could you please run workflow again ?Thanks
@michaelklishin Hello, Could you please send for me if there is any issue? Thanks in advance
Fix Issue in (requeue! and reject! ) For Example: When you are using reject!
Will broker.reject(delivery_info.delivery_tag) -> will go to def reject in broker.rb
Will call channel.reject(delivery_tag, false)-> will go to bunny reject in channel.rb
Will call basic_reject(delivery_tag.to_i, false) which going to reject the message So it's acknowledged
In worker.rb handle_message by default do @broker.ack(delivery_info.delivery_tag) so it's going to be double acknowledged Solution :
Add Boolean in reject and requeue in broker.rb that message rejected
in handle_message before doing default ack check on this boolean