search

ruby-amqp / kicks

The project originally known as Sneakers
MIT License
37 stars 6 forks source link

3.1.0 is incompatible with rails 7.1.x #20

Closed anoam closed 1 hour ago

anoam commented 2 hours ago

The thing is ActiveJob::QueueAdapters::AbstractAdapter first time appears only in Rails 7.2.0.

How to reproduce: 1.

gem install rails -v 7.1.5
rails new test_kicks
cd test_kicks/

  1. Add gem "kicks", "3.1.0" to Gemfile

  2. bundle install

  3. In the rails console

    require 'sneakers'

    rises

    uninitialized constant ActiveJob::QueueAdapters::AbstractAdapter (NameError)

class SneakersAdapter < ::ActiveJob::QueueAdapters::AbstractAdapter
                                                  ^^^^^^^^^^^^^^^^^
Did you mean?  AbstractController
simi commented 1 hour ago

seems related to https://github.com/ruby-amqp/kicks/pull/19, we will release new version to fix this soon :pray:

michaelklishin commented 1 hour ago

This is exactly why #19 was submitted.

michaelklishin commented 1 hour ago

I'm going to cut a new release.

simi commented 1 hour ago

I'm going to cut a new release.

:muscle: