Use convert_options if available.

ruby-av / paperclip-av-transcoder

Audio/Video Transcoder for Paperclip using FFMPEG/Avconv

MIT License

135 stars 83 forks source link

Use convert_options if available. #5

Closed edk closed 9 years ago

edk commented 9 years ago

Currently, passing in :convert_options => {...} as part of a style does not get used by the paperclip processor. This prevents additional switches from being passed to ffmpeg/av.

This change adds the passed options to the cli object.

owahab commented 9 years ago

Re-running after accepting https://github.com/ruby-av/av/pull/1

owahab commented 9 years ago

Can you please rebase on top of the current master? I updated the gem requirements to av >= 0.8.0

edk commented 9 years ago

Hi @owahab I'd like to leave this closed for now. I missed the options that are needed for input/output that are already there in the code originally :) The current code in this gem should work, as-is.

If after some more use in my project, if I find anything that needs updating I'll open a new PR. Thanks for the project!

owahab commented 9 years ago

Alright, thank you :)