ruby-bench / ruby-bench-web

Long Running Ruby Benchmarks
https://rubybench.org
MIT License
82 stars 47 forks source link

Use minitest-rails-capybara for acceptance tests #225

Closed bmarkons closed 7 years ago

bmarkons commented 7 years ago

Acceptance tests were flaky for some time due to possible race conditions.

I found out that Capybara shouldn't be used with integration test (ActionDispatch::IntegrationTest), therefore I replaced it with Capybara::Rails::TestCase. http://blowmage.com/minitest-rails-capybara/

It looks like this recovered test suite - I've run it 10 times in for loop and no flaky error was raised.

tgxworld commented 7 years ago

@bmarkons Nice find :+1: