ruby-bench / ruby-bench-web

Long Running Ruby Benchmarks
https://rubybench.org
MIT License
82 stars 47 forks source link

Rename models [WIP] #226

Closed bmarkons closed 7 years ago

bmarkons commented 7 years ago

This PR is part of my contributions on stuff I found hard to follow while getting familiar with the code.

I was confused a bit with model naming therefore I suggest these changes:

@tgxworld WDYT?

bmarkons commented 7 years ago

It looks like model can't be named Benchmark because of name conflict with ruby module, which is required by default. :man_facepalming:

https://stackoverflow.com/questions/44903703/how-to-avoid-module-conflicts-in-rails

tgxworld commented 7 years ago

Hmm I think BenchmarkResultType sounds OK though.

bmarkons commented 7 years ago

@tgxworld at first I was mainly confused with having two kind of types BenchmarkType and BenchmarkResultType.

Though I wasn't quite sure in naming I've proposed here, so I'll discard it.

Thanks for feedback :bowing_man: