Improve comparison chart

ruby-bench / ruby-bench-web

Long Running Ruby Benchmarks

https://rubybench.org

MIT License

82 stars 47 forks source link

Improve comparison chart #231

Closed bmarkons closed 7 years ago

bmarkons commented 7 years ago

Work regarding https://github.com/ruby-bench/ruby-bench-web/issues/230 :hammer_and_wrench:

bmarkons commented 7 years ago

I've replaced highcharts with highstock since it better suits our needs for comparison chart. I made a screenshot of improved comparison chart below.

I decided to separate building comparison chart from existing ChartBuilder and move it to ComparisonChartBuilder therefore I reverted changes made to ChartBuilder made with introducing comparison charts at first.

Probably would be the best to separate comparison charts from existing ones entirely as separate page.

Thoughts? :)

bmarkons commented 7 years ago

@tgxworld May I merge this one?

This PR only affects comparison chart.

tgxworld commented 7 years ago

Thank you @bmarkons, looking good to me.