search

ruby-concurrency / concurrent-ruby

Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.
https://ruby-concurrency.github.io/concurrent-ruby/
Other
5.71k stars 420 forks source link

Fix broken CI due to rake-compiler error on Ruby < 2.6 #1007

Closed mattbrictson closed 1 year ago

mattbrictson commented 1 year ago

The recently released rake-compiler 1.2.4 breaks compatibility with Ruby 2.5 and below. It is causing concurrent-ruby CI jobs to fail with errors like this:

NoMethodError: undefined method `cleanpath' for "tmp/x86_64-linux/concurrent_ruby_ext/2.3.8":String

The rake-compiler regression has been reported here:

https://github.com/rake-compiler/rake-compiler/issues/224

As a workaround, this PR updates the ruby-concurrent Gemfile to avoid rake-compiler 1.2.4. This should fix the broken CI jobs.

eregon commented 1 year ago

Thanks! I wondered what caused it.