ruby-concurrency / concurrent-ruby

Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.
https://ruby-concurrency.github.io/concurrent-ruby/
Other
5.71k stars 420 forks source link

Remove dependency on logger #1062

Closed eregon closed 1 month ago

eregon commented 2 months ago

This should be fully compatible and address the warnings. Only if one uses the long-deprecated Concurrent.create_stdlib_logger they might need to add logger to their Gemfile.

kbrock commented 1 month ago

@ioquatix What did you just ask?

  1. Can we drop the method that creates @logger It was introduced to prevent a deadlock and do we still need it? 1
  2. Can drop global logger and have log be a no-op if @logging does not exist? 2
  3. Can we drop all references to the log method? [3]
  4. Other.
ioquatix commented 1 month ago

Probably (1) and (3) - basically remove it entirely.