should we use new c macros included with rubyc?

ruby-concurrency / concurrent-ruby

Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.

https://ruby-concurrency.github.io/concurrent-ruby/

Other

5.7k stars 419 forks source link

should we use new c macros included with rubyc? #897

Open dsisnero opened 3 years ago

dsisnero commented 3 years ago

with https://github.com/ruby/ruby/pull/3983 , rubyc includes c macros to do atomic operations. should we use these for the atomic operations?

Operating system: linux / mac / win
Ruby implementation: Ruby / JRuby / TruffleRuby / Rubinius
concurrent-ruby version: x.y.z
concurrent-ruby-ext installed: yes / no
concurrent-ruby-edge used: yes / no

pitr-ch commented 3 years ago

This is a good idea, thank you for letting me know. Although, the implementation in concurrent-ruby should use these conditionally only when available since it has to support old Ruby versions.