search

ruby-concurrency / concurrent-ruby

Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.
https://ruby-concurrency.github.io/concurrent-ruby/
Other
5.68k stars 418 forks source link

Fixes/improvements to promises.in.md. #961

Closed keithrbennett closed 2 years ago

keithrbennett commented 2 years ago

Great documentation, thank you!

I noticed some things that I thought were unintended, and "fixed" them. ;)

chrisseaton commented 2 years ago

Does anyone have a clue why we'd have written # at the end of these lines like this? Must have been some reason...

chrisseaton commented 2 years ago

These # are definitely supposed to be doing something - they're stripped when the file is processed but I have no idea why.

pitr-ch commented 2 years ago

If I remember correctly. They tell the tool not to add the value of the expression at the end as it does for all the other lines.

keithrbennett commented 2 years ago

@pitr-ch What tool is that?

pitr-ch commented 2 years ago

It uses https://github.com/pitr-ch/md-ruby-eval as far as I remember.

chrisseaton commented 2 years ago

Closed based on explanation. Thanks for the thought, though.