Add `TimerTask#interval_type` option to configure interval calculation

ruby-concurrency / concurrent-ruby

Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.

https://ruby-concurrency.github.io/concurrent-ruby/

Other

5.68k stars 418 forks source link

Add `TimerTask#interval_type` option to configure interval calculation #997

Closed bensheldon closed 8 months ago

bensheldon commented 1 year ago

Can be either :fixed_delay or :fixed_rate, default to :fixed_delay.

Closes #678

Notes:

I would love a better suggestion for the parameter than interval_type
The option names come from @eregon's suggestion to mirror Java's options

ioquatix commented 10 months ago

@bensheldon if you have time, I suggest we make a 2nd PR which uses a derived class, so we can compare the level of complexity.

bensheldon commented 10 months ago

@ioquatix no prob! I'll try to get to that next week.

eregon commented 8 months ago

This looks great, merging, thank you!