search

ruby-debug / debase

BSD 2-Clause "Simplified" License
209 stars 32 forks source link

Support conditional breakpoints within debase. #37

Closed seraku24 closed 7 years ago

seraku24 commented 7 years ago

This should allow debase to be able to perform conditional breakpoint evaluation on its own. Fixes #36.

I have done basic acceptance testing against VS Code* and PuTTY connecting as IDEs. @denofevil, I would be grateful if you could test these changes against RubyMine to confirm that I have not inadvertently broken compatibility.

(* vscode-ruby still has some pending work for enabling conditional breakpoints, so my testing is against a private build at the moment.)

And, thanks to @deivid-rodriguez and the byebug project, which proved to be a helpful resource. (:

deivid-rodriguez commented 7 years ago

@seraku24 You're welcome, feel free to contribute back to byebug any improvements you think byebug could benefit from! :wink:

seraku24 commented 7 years ago

@denofevil, let me know if this works for you. The test code does takes a slightly different path than the real code, but this is the cleanest approach I found that does not overly complicate things.

denofevil commented 7 years ago

@seraku24, I've checked previous version of the code in ruby-debug-base and it seems that position and expression checks were separated, that probably will make tests more clean but also more unit-like. In general LGTM, I can merge this one.

denofevil commented 7 years ago

@seraku24 what do you think, do you want to check previous implementation or we're merging this one?

denofevil commented 7 years ago

It should also fix #11

seraku24 commented 7 years ago

@denofevil, I did not realize you had been waiting on me. I am very sorry about that.

I just reviewed the files you linked. At this point, I do not believe the differences from what we have here should matter in the grand scheme of things.

denofevil commented 7 years ago

@seraku24 no problems, let me merge this then and update the gem

denofevil commented 7 years ago

Pushed debase 0.2.2.beta10 to rubygems.org.