search

ruby-debug / ruby-debug-ide

An interface which glues ruby-debug to IDEs like Eclipse (RDT), NetBeans and RubyMine.
https://www.jetbrains.com/ruby/features/ruby_debugger.html
Other
370 stars 83 forks source link

Fixed syntax error on ruby 1.8 #154

Closed encyphered closed 6 years ago

encyphered commented 6 years ago

Ruby 1.8 does not support default value in block arguments. I have no idea about the project is still support Ruby 1.8, but when notify_dispatcher_if_needed method yield, the 2nd argument that named port_changed cannot be nil. So, I've removed setting false as the default value of an argument.

valich commented 6 years ago

@encyphered We do not add new functionality to older rubies if there are incompatibility difficulties, but we try to make the existing features work properly. Thanks, this fix looks correct.