Improved set of commits

aeden commented 14 years ago

I've pushed a revised set of commits into my repo to break up the changes. Feel free to take what works for you and leave the rest. Thanks!

weppos commented 14 years ago

Excellent! I reviewed the changes and here's my feedback:

I agree with c6775d9b13e487f4a08e46be2349ee8b705dca00 and it will be merged ASAP
I partially agree with d85830ff4e1ec1e7bb81e5a376e65857120b14c0. I agree with you that a NameError is not really a good behavior, it sounds more a bug rather than a feature. However, I'm not really convinced that a warning is enough. Warnings often pass unnoticed, lost in error logs or suppressed by less restrictive log levels. Instead, I'd like to rescue the NameError and raise a customized exception, for instance Resolver::UnknownRecord.

This is my feedback. I'd like to know Marco's feedback on the latter point before proceeding.

Again, thank you very much Anthony!

drnic commented 13 years ago

Bumpety bump :)

weppos commented 13 years ago

Oops, you're right. This pull request got lost in my task list. Added to my TODO list, it should be done in one week. :)

weppos commented 13 years ago

Merged, thank you and sorry for the very long wait. I'll probably customize the behavior introduced by d85830ff4e1ec1e7bb81e5a376e65857120b14c0, but it's ok for now.

ruby-dns / net-dns

Improved set of commits #16