Open bonsaiviking opened 12 years ago
Hello @bonsaiviking,
Thanks for your patch. In order to merge the patch, each change must be validated with an unit test. Would you mind to update the patch?
-- Simone
@weppos I've added the unit tests and rebased against master.
I have forked this repository (after attempting and failing to contact author) here: https://github.com/mordocai/net-dns. If you wish to resubmit your pull request there I will review/merge it in. It will shortly be the gem net-dns2 on rubygems.org.
I have merged your changes (minus tests, i'm writing new rspec tests) into my fork here: https://github.com/mordocai/net-dns/commit/81391af458a033d6a9bff4233c833b7364689cb4. It should be in the v0.8.3 release later this week.
This pull request passes (merged 06fdd7a8 into 4c6aa6e5).