search

ruby-dns / net-dns

Net::DNS is a DNS library written in Ruby.
http://net-dns.rubyforge.org
Other
165 stars 42 forks source link

Simplify nameserver settings (and fix bugs) #60

Closed nullstyle closed 10 years ago

nullstyle commented 10 years ago

This commit makes the method of changing a resolvers nameservers more functional and less buggy. For example, using a hostname rather than ip for setting the nameserver is no longer buggy (the previous implentation would result in preserving the default nameserver and would append the inspected form of the IPAddr object of the new nameserver)

This commit consolidates the location of changing @config[:nameservers] into a single location.

ghost commented 10 years ago

I have forked this repository (after attempting and failing to contact author) here: https://github.com/mordocai/net-dns. If you wish to resubmit your pull request there I will review/merge it in. It will shortly be the gem net-dns2 on rubygems.org.

ghost commented 10 years ago

Merged this in my fork here https://github.com/mordocai/net-dns/commit/9821b2619f2287c0197803a865c24258c41c959e. This should be in the v0.8.3 release later this week.

nullstyle commented 10 years ago

Sweet! Thanks for pulling this into your fork.