search

ruby-dns / net-dns

Net::DNS is a DNS library written in Ruby.
http://net-dns.rubyforge.org
Other
165 stars 43 forks source link

Remove core extensions #79

Closed dduugg closed 5 years ago

dduugg commented 5 years ago

This PR removes the two core extensions, Hash#downcase_keys! (unused) and Hash#- (inlined at single call site).

Monkey-patching the core library can cause problems, such as unintentionally coupling code to the net-dns library (which can break in unanticipated ways when code is refactored), or causing conflicts with other libraries that have conflicting core extensions.

weppos commented 5 years ago

Thanks.

kitop commented 4 years ago

Is there a release with this change planned?