search

ruby-docx / docx

a ruby library/gem for interacting with .docx files
MIT License
431 stars 170 forks source link

Fully Support Styles #145

Closed rickychilcott closed 6 months ago

rickychilcott commented 9 months ago

Implement creating, removing, and editing existing document styles.

It's a massive PR. Sorry.

But it works and it's cool. So it's got that going for it.

rickychilcott commented 9 months ago

Are we still trying to support Ruby 2.6 @satoryu? Thanks for reviewing and considering this change.

satoryu commented 9 months ago

@rickychilcott, thank you for opening this pull request! As you pointed out, support for Ruby 2.6 should be dropped. I will take care of it, so please disregard the failure on Ruby 2.6 at the moment.

satoryu commented 9 months ago

FYI: #146

rickychilcott commented 9 months ago

Cool, thanks! I merged in master and added a bit more documentation!

rickychilcott commented 9 months ago

Hey @satoryu! We've now shipped a feature in our application using my fork, and it's working like a charm. Are you willing to review this to see if we could consider getting this merged in?