ruby-docx / docx

a ruby library/gem for interacting with .docx files
MIT License
435 stars 170 forks source link

Update the nokogiri dependency? #71

Closed abartov closed 4 years ago

abartov commented 5 years ago

Hi!

There's a security vulnerability in nokogiri fixed in version 1.10.4. This gem requires ~>1.8, holding back upgrades of nokogiri. Could you release a version requiring the newer nokogiri, or just >1.8 open-endedly? Thanks!

mvz commented 4 years ago

Hi @abartov, the specification ~> 1.8 already allows 1.10.4, since it specifies the minor version number must be 8 or heigher.

satoryu commented 4 years ago

Updated the dependency 👍 https://github.com/ruby-docx/docx/pull/72/commits/4628bbd64757112e17e06a1ea270835ae24951ae