search

ruby-gettext / gettext

Gettext gem is a pure Ruby Localization(L10n) library and tool which is modeled after the GNU gettext package.
https://ruby-gettext.github.io/
69 stars 28 forks source link

test/tools/test_xgettext.rb has unneeded iconv require #14

Closed mtasaka closed 11 years ago

mtasaka commented 11 years ago

test/tools/test_xgettext.rb has iconv require on the line 21, and it seems this is unneeded. WIth ruby 2.0.0 iconv is removed from ruby-core, so now test fails like:

+ ruby -Ilib:test test/run-test.rb
/usr/share/gems/gems/test-unit-notify-0.3.0/lib/test/unit/notify.rb:106: warning: assigned but unused variable - expire_time
/builddir/build/BUILD/rubygem-gettext-2.3.7/usr/share/gems/gems/gettext-2.3.7/test/test_locale_path.rb:74: warning: assigned but unused variable - default_path_rules
/builddir/build/BUILD/rubygem-gettext-2.3.7/usr/share/gems/gems/gettext-2.3.7/lib/gettext/tools/po.rb:194: warning: assigned but unused variable - msgctxt
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:45:in `require': cannot load such file -- iconv (LoadError)
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:45:in `require'
    from /builddir/build/BUILD/rubygem-gettext-2.3.7/usr/share/gems/gems/gettext-2.3.7/test/tools/test_xgettext.rb:21:in `<top (required)>'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:45:in `require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:45:in `require'
    from test/run-test.rb:44:in `block (2 levels) in <main>'
    from test/run-test.rb:43:in `each'
    from test/run-test.rb:43:in `block in <main>'
    from test/run-test.rb:42:in `chdir'
    from test/run-test.rb:42:in `<main>

(log: http://kojipkgs.fedoraproject.org//work/tasks/3537/5063537/build.log toplevel URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=5063537 )

Just commenting out requiring iconv on the line 21 seems to work.