search

ruby-gettext / gettext

Gettext gem is a pure Ruby Localization(L10n) library and tool which is modeled after the GNU gettext package.
https://ruby-gettext.github.io/
68 stars 28 forks source link

Don't raise on percing some types of percent strings #67

Closed KitaitiMakoto closed 4 years ago

KitaitiMakoto commented 4 years ago

Hi,

I found rxgettext command causes errors when it parses some types of percent strings. It's not preferred behavior although it's not trivial how they should be parsed. So, I just fixed for parser not to raise exceptions.

Could you consider this patch? Feel free to point out non-gettext-style fixture and test method.

Thanks.

KitaitiMakoto commented 4 years ago

@kou Thanks for many advice. I fixed all of what you pointed. Can you review again, please?

kou commented 4 years ago

Merged. Thanks!

KitaitiMakoto commented 4 years ago

Thank you!