ruby-gettext / gettext

Gettext gem is a pure Ruby Localization(L10n) library and tool which is modeled after the GNU gettext package.
https://ruby-gettext.github.io/
68 stars 28 forks source link

3.3.9 does not pass tests without red-datasets #87

Closed mtasaka closed 3 years ago

mtasaka commented 3 years ago

With gettext 3.3.9 without red-datasets:

.................................F
=============================================================================================================================================================================================================
Failure: test_cs(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:384:in `test_cs'
     381:     end
     382: 
     383:     def test_cs
  => 384:       assert_equal("nplurals=3; " +
     385:                    "plural=(n == 1) ? 0 : (n >= 2 && n <= 4) ? 1 : 2;",
     386:                    @msginit.__send__(:plural_forms, "cs"))
     387:     end
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=3; plural=(n == 1) ? 0 : (n >= 2 && n <= 4) ? 1 : 2;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=3; plural=(n == 1) ? 0 : (n >= 2 && n <= 4) ? 1 : 2;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_en(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:335:in `test_en'
     332:     end
     333: 
     334:     def test_en
  => 335:       assert_equal("nplurals=2; plural=n != 1;",
     336:                    @msginit.__send__(:plural_forms, "en"))
     337:     end
     338: 
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=2; plural=n != 1;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=2; plural=n != 1;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_fr(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:340:in `test_fr'
     337:     end
     338: 
     339:     def test_fr
  => 340:       assert_equal("nplurals=2; plural=n > 1;",
     341:                    @msginit.__send__(:plural_forms, "fr"))
     342:     end
     343: 
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=2; plural=n > 1;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=2; plural=n > 1;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_ga(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:353:in `test_ga'
     350:     end
     351: 
     352:     def test_ga
  => 353:       assert_equal("nplurals=5; " +
     354:                    "plural=(n == 1) ? 0 : (n == 2) ? 1 : " +
     355:                    "(n >= 3 && n <= 6) ? 2 : (n >= 7 && n <= 10) ? 3 : 4;",
     356:                    @msginit.__send__(:plural_forms, "ga"))
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=5; plural=(n == 1) ? 0 : (n == 2) ? 1 : (n >= 3 && n <= 6) ? 2 : (n >= 7 && n <= 10) ? 3 : 4;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=5; plural=(n == 1) ? 0 : (n == 2) ? 1 : (n >= 3 && n <= 6) ? 2 : (n >= 7 && n <= 10) ? 3 : 4;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_ja(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:330:in `test_ja'
     327:     end
     328: 
     329:     def test_ja
  => 330:       assert_equal("nplurals=1; plural=0;",
     331:                    @msginit.__send__(:plural_forms, "ja"))
     332:     end
     333: 
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=1; plural=0;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=1; plural=0;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_lt(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:367:in `test_lt'
     364:     end
     365: 
     366:     def test_lt
  => 367:       assert_equal("nplurals=3; " +
     368:                    "plural=((n % 10) == 1) && " +
     369:                    "((n % 100) < 11 || (n % 100) > 19) ? 0 : " +
     370:                    "((n % 10) >= 2 && (n % 10) <= 9) && " +
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=3; plural=((n % 10) == 1) && ((n % 100) < 11 || (n % 100) > 19) ? 0 : ((n % 10) >= 2 && (n % 10) <= 9) && ((n % 100) < 11 || (n % 100) > 19) ? 1 : 2;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=3; plural=((n % 10) == 1) && ((n % 100) < 11 || (n % 100) > 19) ? 0 : ((n % 10) >= 2 && (n % 10) <= 9) && ((n % 100) < 11 || (n % 100) > 19) ? 1 : 2;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_lv(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:345:in `test_lv'
     342:     end
     343: 
     344:     def test_lv
  => 345:       assert_equal("nplurals=3; " +
     346:                    "plural=((n % 10) == 1) && ((n % 100) != 11) ? 0 : " +
     347:                    "((n % 10) == 0) || ((n % 100) >= 11 && (n % 100) <= 19) " +
     348:                    "? 1 : 2;",
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=3; plural=((n % 10) == 1) && ((n % 100) != 11) ? 0 : ((n % 10) == 0) || ((n % 100) >= 11 && (n % 100) <= 19) ? 1 : 2;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=3; plural=((n % 10) == 1) && ((n % 100) != 11) ? 0 : ((n % 10) == 0) || ((n % 100) >= 11 && (n % 100) <= 19) ? 1 : 2;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_pl(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:390:in `test_pl'
     387:     end
     388: 
     389:     def test_pl
  => 390:       assert_equal("nplurals=3; " +
     391:                    "plural=(n == 1) ? 0 : " +
     392:                    "((n % 10) >= 2 && (n % 10) <= 4) && " +
     393:                    "((n % 100) < 12 || (n % 100) > 14) ? 1 : 2;",
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=3; plural=(n == 1) ? 0 : ((n % 10) >= 2 && (n % 10) <= 4) && ((n % 100) < 12 || (n % 100) > 14) ? 1 : 2;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=3; plural=(n == 1) ? 0 : ((n % 10) >= 2 && (n % 10) <= 4) && ((n % 100) < 12 || (n % 100) > 14) ? 1 : 2;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_ro(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:360:in `test_ro'
     357:     end
     358: 
     359:     def test_ro
  => 360:       assert_equal("nplurals=3; " +
     361:                    "plural=(n == 1) ? 0 : " +
     362:                    "(n == 0) || ((n % 100) >= 2 && (n % 100) <= 19) ? 1 : 2;",
     363:                    @msginit.__send__(:plural_forms, "ro"))
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=3; plural=(n == 1) ? 0 : (n == 0) || ((n % 100) >= 2 && (n % 100) <= 19) ? 1 : 2;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=3; plural=(n == 1) ? 0 : (n == 0) || ((n % 100) >= 2 && (n % 100) <= 19) ? 1 : 2;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_ru(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:376:in `test_ru'
     373:     end
     374: 
     375:     def test_ru
  => 376:       assert_equal("nplurals=3; " +
     377:                    "plural=((n % 10) == 1) && ((n % 100) != 11) ? 0 : " +
     378:                    "((n % 10) >= 2 && (n % 10) <= 4) && " +
     379:                    "((n % 100) < 12 || (n % 100) > 14) ? 1 : 2;",
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=3; plural=((n % 10) == 1) && ((n % 100) != 11) ? 0 : ((n % 10) >= 2 && (n % 10) <= 4) && ((n % 100) < 12 || (n % 100) > 14) ? 1 : 2;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=3; plural=((n % 10) == 1) && ((n % 100) != 11) ? 0 : ((n % 10) >= 2 && (n % 10) <= 4) && ((n % 100) < 12 || (n % 100) > 14) ? 1 : 2;
=============================================================================================================================================================================================================
F
=============================================================================================================================================================================================================
Failure: test_sl(TestToolsMsgInit::TestPluralForms)
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:398:in `test_sl'
     395:     end
     396: 
     397:     def test_sl
  => 398:       assert_equal("nplurals=4; " +
     399:                    "plural=((n % 100) == 1) ? 0 : " +
     400:                    "((n % 100) == 2) ? 1 : " +
     401:                    "((n % 100) >= 3 && (n % 100) <= 4) ? 2 : 3;",
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:40:in `block (2 levels) in run'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `chdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:39:in `block in run'
/usr/share/ruby/tmpdir.rb:96:in `mktmpdir'
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-gettext/rawhide/rubygem-gettext-3.3.9/usr/share/gems/gems/gettext-3.3.9/test/tools/test_msginit.rb:38:in `run'
<"nplurals=4; plural=((n % 100) == 1) ? 0 : ((n % 100) == 2) ? 1 : ((n % 100) >= 3 && (n % 100) <= 4) ? 2 : 3;"> expected but was
<"nplurals=; plural=;">

diff:
? nplurals=4; plural=((n % 100) == 1) ? 0 : ((n % 100) == 2) ? 1 : ((n % 100) >= 3 && (n % 100) <= 4) ? 2 : 3;
=============================================================================================================================================================================================================
.....................................................................................................
Finished in 4.795605263 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
378 tests, 744 assertions, 11 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
97.0822% passed

Looks like https://github.com/ruby-gettext/gettext/blob/78adcfd6635a1cfd9a865fecf40e66a8b7889085/lib/gettext/tools/msginit.rb#L379 does nothing when red-datasets is not installed. Is this intentional? At least it is pleased that test suite passes even without red-datasets.

kou commented 3 years ago

Ah, sorry. I've added Red Datasets availability check to tests.

mtasaka commented 3 years ago

3.4.0 is good, thank you!