Use env to pass AMS meta around.

ruby-grape / grape-active_model_serializers

User active_model_serializers with Grape

MIT License

139 stars 68 forks source link

Use env to pass AMS meta around. #40

Closed dblock closed 9 years ago

dblock commented 9 years ago

I think this is better than passing things through a module class variable, but I am not 100% sure. This avoids theoretical concurrency issues and possibly some GC.

siong1987 commented 9 years ago

LGTM. I always opt for lesser code and your point on concurrency issues makes sense.

as long as this doesn't break backward compatibility, merge it!

dblock commented 9 years ago

Thanks, merged.