ruby-grape / grape-active_model_serializers

User active_model_serializers with Grape
MIT License
140 stars 68 forks source link

`include: '**'` option not working on serailizers #69

Closed JWesorick closed 7 years ago

JWesorick commented 7 years ago

Per rails-api/active_model_serializers#2081 I'm trying to include all levels for one of my endpoints. But it seems the includes option isn't working with this gem.

drn commented 7 years ago

@JWesorick, are you using v1.5.0, master, or another version? Should be an easy fix, but that info would help point us in the right direction

JWesorick commented 7 years ago

v1.5.0

drn commented 7 years ago

Got it - I'll dig

drn commented 7 years ago

@JWesorick - can you try out these changes? https://github.com/ruby-grape/grape-active_model_serializers/pull/73

gem 'grape-active_model_serializers',
  github: 'ruby-grape/grape-active_model_serializers',
  branch: 'pass-ams-options'
JWesorick commented 7 years ago

@drn Yep that works!

drn commented 7 years ago

Awesome, sorry for the delay. Been hectic at work. I'll get this merged in sometime over the next few days and release a new gem version

JWesorick commented 7 years ago

Thanks!

drn commented 7 years ago

v1.5.1 has been released!