search

ruby-grape / grape-entity

An API focused facade that sits on top of an object model.
MIT License
721 stars 153 forks source link

Removed 'require pry' #324

Closed anakinj closed 4 years ago

anakinj commented 5 years ago

This would probably brake prod environments.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.01%) to 95.835% when pulling b56c1db18c004fc09c83c8d071e4601018cbf1f0 on anakinj:remove-require-pry into 53b250299855dd8be5db4c14b31a9c5d663b42ef on ruby-grape:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.01%) to 95.835% when pulling b56c1db18c004fc09c83c8d071e4601018cbf1f0 on anakinj:remove-require-pry into 53b250299855dd8be5db4c14b31a9c5d663b42ef on ruby-grape:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.01%) to 95.835% when pulling b56c1db18c004fc09c83c8d071e4601018cbf1f0 on anakinj:remove-require-pry into 53b250299855dd8be5db4c14b31a9c5d663b42ef on ruby-grape:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.004%) to 95.851% when pulling 54b0c3d6174e7e80fa629680b736fa0a215490dc on anakinj:remove-require-pry into cf146b75701b6155b6f0a07b68a2325bdb456340 on ruby-grape:master.

grape-bot commented 4 years ago
1 Error
:no_entry_sign: One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
2 Warnings
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.
:warning: There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code. 
* [#307](https://github.com/ruby-grape/grape-entity/pull/307): Allow exposures to call methods defined in modules included in an entity [@robertoz-01](https://github.com/robertoz-01).

Here's an example of a CHANGELOG.md entry:

* [#324](https://github.com/ruby-grape/grape-entity/pull/324): Removed 'require pry' - [@anakinj](https://github.com/anakinj).

Generated by :no_entry_sign: danger

LeFnord commented 4 years ago

thanks @anakinj