search

ruby-grape / grape-rabl

Use rabl with grape
MIT License
136 stars 29 forks source link

Hotfix/tests #16

Closed lloydmeta closed 11 years ago

LTe commented 11 years ago

Hi @lloydmeta, thanks for your pull request. It's great that you give something to the open-source community. Can you explain to me reason why you created this pull request? You know, when there is problem usually there is pull request for that :). What problem or inconvenience solve your pull request?

I leave few comments on code. Also travis cannot build your pull request. Specs fails also on my localhost. So look at this.

Have a nice day!

lloydmeta commented 11 years ago

Hi @LTe,

The reason for the pull request request was because your project was failing it's own tests, but I think you've by now realised this as I can see you've made some fixes here today: https://github.com/LTe/grape-rabl/commit/c3b707ba4a8f3534a6a05425f0b64e838b766d36 :)

I think there were some errors on my part (with the .rvmrc file and the modifying of line 20 in formatter.rb), but it looks like I helped. Also, travis failing was due to ruby-head issues on their end. (https://travis-ci.org/LTe/grape-rabl/jobs/8377036)

Cheers,

Lloyd

LTe commented 11 years ago

The reason for the pull request request was because your project was failing it's own tests, but I think you've by now realised this as I can see you've made some fixes here today: c3b707b :)

Yes :)

but it looks like I helped

Of course, you are awesome!

Also, travis failing was due to ruby-head issues on their end. (https://travis-ci.org/LTe/grape-rabl/jobs/8377036)

I already ask travis team to investigate this issue. Ruby-head can not download bundler. Build fails because of travis issue.