Change grape dependency to support new versions

ruby-grape / grape-rabl

Use rabl with grape

MIT License

136 stars 29 forks source link

Change grape dependency to support new versions #20

Closed cheef closed 10 years ago

cheef commented 10 years ago

New grape version working fine for me with this gem

coveralls commented 10 years ago

Coverage decreased (-0.13%) when pulling ef5682ab78f312d56d99fe4b8e3e15bdadd19f2c on cheef:master into f16bfb2f6ec3976f434c07920172e8b8f58f9e03 on LTe:master.

dblock commented 10 years ago

Add a Next Release section to CHANGELOG and a 1-liner that says something like "Relaxed dependency on a specific version of Grape", please.

Make these changes via git commit --amend, please.

dblock commented 10 years ago

One more thing, the README tells you to use a specific version of things, would you mind fixing that, too? Appreciate it.

cheef commented 10 years ago

I think it's better to change vesion in README too, agree?

dblock commented 10 years ago

I mean we say gem 'grape', "~> 0.2.3", it should just say gem 'grape' probably.

coveralls commented 10 years ago

Coverage decreased (-0.13%) when pulling 4673aa89fa8f0ce1f275fa3f8175f375e58120cf on cheef:master into f16bfb2f6ec3976f434c07920172e8b8f58f9e03 on LTe:master.

cheef commented 10 years ago

Added all changes

coveralls commented 10 years ago

Coverage decreased (-0.13%) when pulling c3933311b197c0e0353813a24a749e097df39fe6 on cheef:master into f16bfb2f6ec3976f434c07920172e8b8f58f9e03 on LTe:master.

coveralls commented 10 years ago

Coverage increased (+0.48%) when pulling 8ac20a02f24324f411ddae55cd139f1b3dd0760f on cheef:master into f16bfb2f6ec3976f434c07920172e8b8f58f9e03 on LTe:master.

coveralls commented 10 years ago

Coverage increased (+0.48%) when pulling 56da0a5bcecb16501cdd93ac25f3b6ca6d7a86f0 on cheef:master into f16bfb2f6ec3976f434c07920172e8b8f58f9e03 on LTe:master.

dblock commented 10 years ago

Merging, thanks for being patient with the nitpicking.

dblock commented 10 years ago

0.2.2 released

LTe commented 10 years ago

@cheef thank for this pull request. You are awesome :+1: @dblock thank for release! :heart: