search

ruby-grape / grape-rabl

Use rabl with grape
MIT License
136 stars 29 forks source link

make grape-rabl formatter thread-safe #38

Closed kushkella closed 9 years ago

kushkella commented 9 years ago

https://github.com/LTe/grape-rabl/issues/37

I think tilt_cache is still not thread-safe since it is being lazy loaded and so are the templates. I'm not sure what we should do about it. The similar issue is present in rabl gem. https://github.com/nesquena/rabl/blob/776e6c5f062c0feaf26d78bb8288ee2b97a93c17/lib/rabl.rb#L59

Thanks!

dblock commented 9 years ago

Well done. Can you please update https://github.com/LTe/grape-rabl/blob/master/CHANGELOG.md?

dblock commented 9 years ago

I think we need to eager-load tilt_cache or something of that nature. Deal with it separately.

dblock commented 9 years ago

Good, I'm merging this.

kushkella commented 9 years ago

It would be great if you can release a new version of this gem. Thanks!

dblock commented 9 years ago

Just to be on the safe side I bumped us to 0.4.0 and cut a release.

LTe commented 9 years ago

@dblock thanks for your help! :heart:

kushkella commented 9 years ago

Thanks a lot!