Closed padde closed 1 month ago
@padde Thanks! Will you please add Ruby 3.3 to CI and make sure it passes? https://github.com/ruby-grape/grape-swagger-rails/blob/master/.github/workflows/test.yml
1 Warning | |
---|---|
:warning: | Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md. |
1 Message | |
---|---|
:book: | We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests! |
Here's an example of a CHANGELOG.md entry:
* [#122](https://github.com/ruby-grape/grape-swagger-rails/pull/122): Add ostruct to gemspec dependencies - [@padde](https://github.com/padde).
Generated by :no_entry_sign: Danger
Thanks @dblock
I think a lot of specs are failing here because with Rails 7, calling warn
on the singleton instance of ActiveSupport::Deprecation
is, well... deprecated. See rails/rails#47354
I will first work on that.
Thanks, lmk if you need help. Let's have a matrix with various rails versions eventually too.
For reference: https://github.com/ruby-grape/grape-swagger-rails/pull/124
@dblock good point about the CI matrix, I did that as well but in a separate PR: https://github.com/ruby-grape/grape-swagger-rails/pull/125
And finally, this PR will then fix compatibility with the upcoming Ruby 3.5 release: https://github.com/ruby-grape/grape-swagger-rails/pull/126
Fixes #121
This gem was historically included in the default gemset. Starting with Ruby 3.3.5 though, requiring
ostruct
without explicitly adding it as dependency generates the following warning: