search

ruby-grape / grape-swagger-rails

Swagger UI as Rails Engine for grape-swagger gem.
MIT License
252 stars 197 forks source link

Add rails versions to CI matrix #125

Closed padde closed 2 months ago

padde commented 2 months ago

As suggested, here's my proposal to test against multiple Rails versions in the CI matrix. The new config will effectively run the tests against the following versions:

Workflow ruby rails grape-swagger
Tests 2.7 6.1.7 1.6.1
Tests 3.0 6.1.7 1.6.1
Tests 3.1 6.1.7 1.6.1
Tests 3.1 6.1.7 2.0.2
Tests 3.1 7.2.1 1.6.1
Tests 3.1 7.2.1 2.0.2
Tests 3.2 6.1.7 1.6.1
Tests 3.2 6.1.7 2.0.2
Tests 3.2 7.2.1 1.6.1
Tests 3.2 7.2.1 2.0.2
Tests jruby-9.4.6 6.1.7 1.6.1
Tests jruby-9.4.6 6.1.7 2.0.2
Tests jruby-9.4.6 7.2.1 1.6.1
Tests jruby-9.4.6 7.2.1 2.0.2
Tests (HEAD) 3.2 edge HEAD
Tests (HEAD) jruby-head edge HEAD
Tests (HEAD) ruby-head edge HEAD

Blockers

padde commented 2 months ago

@dblock please check out my changes. I think the CI matrix config is fine, however some new test failures seem to be popping up that I haven't seen in the last runs, specifically with grape-swagger v2.0.2. Seems unrelated to the changes in this PR and confirmed that the old CI setup on master also fails for all grape-swagger v2.0.2 versions.

There are warnings about geckodriver being incompatible with the effectively used Firefox version 130.0 (although 111.0.1 is being requested) - I'll see if I can bump those to the current versions to fix the tests.

Update: the Firefox/geckodriver versions have nothing to do with the failures, probably still a good idea to stay up to date there. See #127

Update: the issues seem to be related to the latest grape release 2.2.0 which has removed Grape::ContentTypes::CONTENT_TYPES and is now incompatible with the latest grape-swagger release 2.1.0 , which still references this constant. See https://github.com/ruby-grape/grape-swagger/issues/939

dblock commented 2 months ago

Let's get https://github.com/ruby-grape/grape-swagger/issues/939 in and then we can test HEAD here with HEAD of that project too and get it all to green?

padde commented 2 months ago

@dblock can you please trigger a re-run on CI here? Everything should now turn green after the grape-swagger 2.1.1 release

I don’t have the necessary permissions to do it.

padde commented 2 months ago

@dblock never mind, force push does the trick as well 😉

HEAD is green, we just need to bump grape-swagger to 2.1.1 so it starts working again with the grape 2.2.0 (bundler automatically selected latest version).