Taking swagger-ui from rails-assets

ruby-grape / grape-swagger-rails

Swagger UI as Rails Engine for grape-swagger gem.

MIT License

249 stars 193 forks source link

Taking swagger-ui from rails-assets #83

Open ktimothy opened 7 years ago

ktimothy commented 7 years ago

Hey, this is a very nice project, but keeping swagger-ui dist files in the repository among with rake-task for downloading them makes me sad. I have an idea to add swagger-ui dist as a dependency in Gemfile. I can even make a PR with that. What do you think?

dblock commented 7 years ago

Yes! Making swagger-ui a dist gem and making it a dependency is something we'd take here.

dblock commented 5 years ago

The newer swagger-ui-dist makes this easier. We should be doing something like https://github.com/artsy/doppler/pull/139. Maybe someone wants to take a stab?

mleszcz commented 4 years ago

Yeah. Update task doesn't seem to work anymore

$ bundle exec rake swagger_ui:dist:update
Cloning into /tmp/swagger-ui20190806-10968-xymd0x ...
Removing files from /home/user/apps/some_app ...
Copying Javascripts ...
rake aborted!
Errno::ENOENT: No such file or directory @ apply2files - /home/user/apps/some_app/app/assets/javascripts/grape_swagger_rails

Would be great to be able to update swagger_ui....

dblock commented 4 years ago

Yeah. Update task doesn't seem to work anymore

$ bundle exec rake swagger_ui:dist:update
Cloning into /tmp/swagger-ui20190806-10968-xymd0x ...
Removing files from /home/user/apps/some_app ...
Copying Javascripts ...
rake aborted!
Errno::ENOENT: No such file or directory @ apply2files - /home/user/apps/some_app/app/assets/javascripts/grape_swagger_rails

Would be great to be able to update swagger_ui....

Feel free to debug and PR! Thank you.