search

ruby-grape / grape-swagger-rails

Swagger UI as Rails Engine for grape-swagger gem.
MIT License
251 stars 197 forks source link

Added the token api_auth type #84

Closed Jack12816 closed 6 years ago

Jack12816 commented 7 years ago

Hey guys, first things first: thanks for this great gem!

It would be quite useful to have a new token authentication type, which follows the Rails convention. So the Authorization header looks like this:

Authorization: Token token="WCZZYjnOQFUYfJIN2ShH1iD24UHo58A6TI"

This PR allows the usage of this authentication.

dblock commented 7 years ago

Needs tests and CHANGELOG please.

Jack12816 commented 7 years ago

on my way :)

dblock commented 6 years ago

What about tests. There're actually working tests for these scenarios in https://github.com/ruby-grape/grape-swagger-rails/blob/master/spec/features/swagger_spec.rb#L84. Thanks!

Jack12816 commented 6 years ago

I close this PR due to the long delay of my side and due to the fact that my organization has now a bunch of apps which use my fork/master version which would break on all sides when I squash the commits. Follow up: https://github.com/ruby-grape/grape-swagger-rails/pull/86