search

ruby-grape / grape

An opinionated framework for creating REST-like APIs in Ruby.
http://www.ruby-grape.org
MIT License
9.86k stars 1.22k forks source link

More rubocop #2422

Closed dgutov closed 3 months ago

dgutov commented 3 months ago

Two steps here.

The first tweaks or disables most of the cops that --auto-gen-config commended.

The second is an attempt to fix the "leaky constant" problem that two other cops aim to warn about. I figured that's useful enough to have checked, to avoid this class of test interdependence problems (related: #1165). But the solution is more codegen-ish, so -- see if you like it.

grape-bot commented 3 months ago
1 Warning
:warning: Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.
1 Message
:book: We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#2422](https://github.com/ruby-grape/grape/pull/2422): More rubocop - [@dgutov](https://github.com/dgutov).

Generated by :no_entry_sign: Danger

dblock commented 3 months ago

Great work, thank you!