search

ruby-grape / grape

An opinionated framework for creating REST-like APIs in Ruby.
http://www.ruby-grape.org
MIT License
9.88k stars 1.22k forks source link

Replace Appraisals by eval_gemfile ? #2428

Closed ericproulx closed 5 months ago

ericproulx commented 5 months ago

Most gemfiles are sharing the same structure/gems and when it's time to update dependencies, we have to update all the them. Recently, I came across Bundler's DSL where you can call eval_gemfile in it.

For instance gemfiles/rack_3_0.gemfile could by simplify as

# frozen_string_literal: true

eval_gemfile '../Gemfile'

gem 'rack', '~> 3.0.0'

That way all specific Gemfiles could rely on the base Gemfile to fill the common structure and we could drop Appraisals

dblock commented 5 months ago

Interesting. Appraisals are generated by a tool from spec, so does this really help or make it more confusing when adding new ones?

ericproulx commented 5 months ago

Personnally, when creating a new Gemfile, I just copy/past from an existing one and changing the gem manually. Configuring Appraisals feels cumbersome.

ericproulx commented 5 months ago

Done #2431