Isolate extensions within specific Gemfile - Githubissues

ruby-grape / grape

An opinionated framework for creating REST-like APIs in Ruby.

http://www.ruby-grape.org

MIT License

9.86k stars 1.22k forks source link

Isolate extensions within specific Gemfile #2430

Closed ericproulx closed 3 months ago

ericproulx commented 3 months ago

With the newest addition of dry-validation that has its own Gemfile, I thought it would be great to revisit the remaining one and apply the same pattern by keeping isolation in mind since they all come with their dependencies. IMHO, it feels better this way while keeping it simple for future extensions.

This PR, isolates the following extensions within its own Gemfile and moved the specs accordingly:

hashie
grape-entity
dry-validation

dry-validation has been revisited to be really isolated from all the others.

grape-bot commented 3 months ago

	1 Message
:book:	We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by :no_entry_sign: Danger