search

ruby-grape / grape

An opinionated framework for creating REST-like APIs in Ruby.
http://www.ruby-grape.org
MIT License
9.86k stars 1.22k forks source link

Remove builder as a dependency #2445

Closed ericproulx closed 1 month ago

ericproulx commented 2 months ago

Fix #2443

grape-bot commented 2 months ago
1 Message
:book: We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by :no_entry_sign: Danger

ericproulx commented 1 month ago

The README also needs an update around XML to say builder needs to be added in certain circumstances.

Also, no tests failed?

It's in the our test Gemfile

dblock commented 1 month ago

The README also needs an update around XML to say builder needs to be added in certain circumstances. Also, no tests failed?

It's in the our test Gemfile

Does it make sense to remove it from there and move XML tests to integration? Probably does, can be done in a separate PR.