ruby-grape / grape

An opinionated framework for creating REST-like APIs in Ruby.
http://www.ruby-grape.org
MIT License
9.85k stars 1.22k forks source link

support for msgpack #668

Open alec-c4 opened 10 years ago

alec-c4 commented 10 years ago

Hi, guys. Could you please add support for msgpack (http://msgpack.org) in grape? I've found https://github.com/rosylilly/grape-msgpack, but i think it will be better to have msgpack support as part of grape.

mbleigh commented 10 years ago

@dblock your call, but my vote would be :-1:

In general there are already things in Grape that I'd prefer we break out into separate gems, so I'm definitely not interested in adding more dependencies to the core lib.

dblock commented 10 years ago

I agree with @mbleigh, we want Grape to be more modular vs. less modular as it grows. I'd love a PR that talks about msgpack support in README though, please?

purezen commented 9 years ago

You mean, a link to the grape-msgpack repo? @dblock

dblock commented 9 years ago

See, I didn't know about https://github.com/rosylilly/grape-msgpack :) So yes, feel free to call that out the same way we talk about ActiveModelSerilizers for example.