search

ruby-hacking-guide / ruby-hacking-guide.github.com

Ruby Hacking Guide Translation
http://ruby-hacking-guide.github.io/
318 stars 50 forks source link

Chapter 5 Broken Images #11

Closed mcfilib closed 11 years ago

mcfilib commented 11 years ago

The images figures in the garbage collection chapter are broken.

http://ruby-hacking-guide.github.io/gc.html http://loveruby.net/ja/rhg/book/gc.html

Is it worth including the untranslated versions as a temporary measure?

ocha- commented 11 years ago

Could you check chapter05.html instead of gc.html ?

markburns commented 11 years ago

@ocha- I wonder if you are adding the filenames in as they were. At one point I changed the filenames to match the titles of the pages, so that URLs on the github jekyll website are more readable. I have no problem with adding the chapter number to the title of the page, or to the end of the URL, if you prefer. If you are replacing chapters then it's better to overwrite the existing files than to leave the old ones in.

On 13 August 2013 02:43, ocha- notifications@github.com wrote:

Could you check chapter05.html instead of gc.html ?

— Reply to this email directly or view it on GitHubhttps://github.com/ruby-hacking-guide/ruby-hacking-guide.github.com/issues/11#issuecomment-22538411 .

ocha- commented 11 years ago

I provided the rest of the translation made by @skra last year, it is chapter05.html. And gc.html is probably not a pure translation, and it was faster just to translate from the original book instead of starting from the file.

I thought it's better to make the final decision, whether trying to merge the contents of two files or just replacing it, after checking the content of gc.html again. But I delayed the decision and set the higher priority to the other untranslated chapters.

I think we should not change the file names further. In any ways, the file name of chapter 05 will be gc.html.

markburns commented 11 years ago

That makes sense. I guess that as we have more eyes on this project at the moment, it may make more sense to replace chapter05 with gc, (gc.html is the page linked to on the github pages) if that translation is further along/preferable. Then we won't get fixes for the errors in that page whilst you are working on another.

On 13 August 2013 05:40, ocha- notifications@github.com wrote:

I provided the rest of the translation made by @skrahttps://github.com/skralast year, it is chapter05.html. And gc.html is probably not a pure translation, and it was faster just to translate from the original book instead of starting from the file.

I thought it's better to make the final decision, whether trying to merge the contents of two files or just replacing it, after checking the content of gc.html again. But I delayed the decision and set the higher priority to the other untranslated chapters.

I think we should not change the file names further. In any ways, the file name of chapter 05 will be gc.html.

— Reply to this email directly or view it on GitHubhttps://github.com/ruby-hacking-guide/ruby-hacking-guide.github.com/issues/11#issuecomment-22542870 .

mcfilib commented 11 years ago

Ah, yes, the images on http://ruby-hacking-guide.github.io/chapter05.html load fine. Although, you will see some of the images on that page still contain untranslated Japanese text.

Might it be agreeable to link to chapter05 from the contents page or replace gc with the contents of chapter05?

markburns commented 11 years ago

Agreed with @unsymbol about changing the contents but closing this issue for now

ocha- commented 11 years ago

@markburns After I checked the content of gc.html again, I decided just to replace it with chapter05.html.

I'm glad if you agree with it by checking how different gc.html from chapter05.html. chapter05.html is accurate as a translation and finished. I know you can also compare the contents with the original book.

markburns commented 11 years ago

Sounds good to me

On Wednesday, 14 August 2013, ocha- wrote:

@markburns https://github.com/markburns After I checked the content of gc.html again, I decided just to replace it with chapter05.html.

I'm glad if you agree with it by checking how different gc.html from chapter05.html. chapter05.html is accurate as a translation and finished. I know you can also compare the contents with the original book.

— Reply to this email directly or view it on GitHubhttps://github.com/ruby-hacking-guide/ruby-hacking-guide.github.com/issues/11#issuecomment-22623681 .

ocha- commented 11 years ago

Thanks :)