Closed yasulab closed 11 years ago
I'm glad if you check the generated intro.html by running jekyll locally. Your translation contains some wrong markups.
.p(emlist)
is different from the original book, and this syntax requires a certain strict way to use, for instance, multiple newlines are interpreted as the end of the block.
<pre class="emlist">
...
</pre>
Writing like this is simpler.
I think your translation is good but probably I can suggest a few corrections if you don't mind.
@ocha-
I'm glad if you check the generated intro.html by running jekyll locally.
Okay, I'll find out the wrong tags by locally running Jekyll. And I'll commit the debugged files to this branch. :+1:
but probably I can suggest a few corrections if you don't mind.
No problem! As noted above, we're glad to be corrected. :smile:
We're really glad if someone help reviewing and correcting our translations to merge.
Thank you very much for your cooperation :+1:
@ocha-
I checked out and fixed all the errors by Jekyll.
Also, I found there is no favicon.ico
for Ruby Hacking Guide, so I added it.
Let me know if it's a problem. I'll revert it if it matters.
Thanks for the favicon (and the translation efforts of course). I can't imagine why the favicon should be a problem
The sense of "this is unnatural" by native English speakers is very valuable. I'm also really glad to see the information like "I cannot get the meaning of this sentence". You can just let me correct it when it is necessary.
@johnnymugs
I added new lines to our works in order to make them easier to review, and translate the rest of section. :smile:
I reviewed intro.html from the beginning, but this commit only contains the suggestions for the recent commit. For the other parts, should I push it to this branch? Or I'll just push it to the master.
@ocha-
For the other parts, should I push it to this branch?
If the commit is related to Intro chapter, please push it to this branch, because it's easier for us to update Intro chapter to the latest version.
Sure :)
@yasulab
Do you know about git pull --rebase
? Or you don't like using it?
@ocha-
Oops, I know --rebase
, but I often forget to use that. I think I'm too familiar with typing git pull origin #{branch_name}
.
I'll use --rebase
from now.
@yasulab I just thought it's good to suggest if you didn't know :)
Thanks for your suggestion :smile:
@yasulab Do you mind if I translate the rest of this chapter and merge this branch to the master?
No, because I'm becoming busy, I'm glad if you help translating the rest of this chapter.
@johnnymugs Can you locally type git push origin intro
(using your .gitconfig
) to update our translation to the latest? It would be helpful for @ocha- to translate the rest of this chapter.
Done! Sorry for the delay, I was out.
@johnnymugs Thanks! :smile:
@ocha- This intro
branch is now up-to-date. I think it is good timing for us to relay.
Thanks! Then, I'll take over this branch :+1:
Super :cool: !! :+1:
@yasulab I like the favicon you created :) Thank you very much.
In the same way as translating Preface, Junichi Chiba, Shozo Hatta, Johnny Mukai (@johnnymugs), and I (@yasulab) are translating Intro into English.
We focus on roughly translating from Japanese into English. We're really glad if someone help reviewing and correcting our translations to merge.