ruby-hacking-guide / ruby-hacking-guide.github.com

Ruby Hacking Guide Translation
http://ruby-hacking-guide.github.io/
318 stars 52 forks source link

Translate Intro #25

Closed yasulab closed 11 years ago

yasulab commented 11 years ago

In the same way as translating Preface, Junichi Chiba, Shozo Hatta, Johnny Mukai (@johnnymugs), and I (@yasulab) are translating Intro into English.

We focus on roughly translating from Japanese into English. We're really glad if someone help reviewing and correcting our translations to merge.

ocha- commented 11 years ago

I'm glad if you check the generated intro.html by running jekyll locally. Your translation contains some wrong markups.

.p(emlist)

is different from the original book, and this syntax requires a certain strict way to use, for instance, multiple newlines are interpreted as the end of the block.

<pre class="emlist">
...
</pre>

Writing like this is simpler.

I think your translation is good but probably I can suggest a few corrections if you don't mind.

yasulab commented 11 years ago

@ocha-

I'm glad if you check the generated intro.html by running jekyll locally.

Okay, I'll find out the wrong tags by locally running Jekyll. And I'll commit the debugged files to this branch. :+1:

but probably I can suggest a few corrections if you don't mind.

No problem! As noted above, we're glad to be corrected. :smile:

We're really glad if someone help reviewing and correcting our translations to merge.

ocha- commented 11 years ago

Thank you very much for your cooperation :+1:

yasulab commented 11 years ago

@ocha-

I checked out and fixed all the errors by Jekyll.

yasulab commented 11 years ago

Also, I found there is no favicon.ico for Ruby Hacking Guide, so I added it.

Let me know if it's a problem. I'll revert it if it matters.

markburns commented 11 years ago

Thanks for the favicon (and the translation efforts of course). I can't imagine why the favicon should be a problem

ocha- commented 11 years ago

The sense of "this is unnatural" by native English speakers is very valuable. I'm also really glad to see the information like "I cannot get the meaning of this sentence". You can just let me correct it when it is necessary.

yasulab commented 11 years ago

@johnnymugs

I added new lines to our works in order to make them easier to review, and translate the rest of section. :smile:

ocha- commented 11 years ago

I reviewed intro.html from the beginning, but this commit only contains the suggestions for the recent commit. For the other parts, should I push it to this branch? Or I'll just push it to the master.

yasulab commented 11 years ago

@ocha-

For the other parts, should I push it to this branch?

If the commit is related to Intro chapter, please push it to this branch, because it's easier for us to update Intro chapter to the latest version.

ocha- commented 11 years ago

Sure :)

ocha- commented 11 years ago

@yasulab Do you know about git pull --rebase ? Or you don't like using it?

yasulab commented 11 years ago

@ocha-

Oops, I know --rebase, but I often forget to use that. I think I'm too familiar with typing git pull origin #{branch_name}.

I'll use --rebase from now.

ocha- commented 11 years ago

@yasulab I just thought it's good to suggest if you didn't know :)

yasulab commented 11 years ago

Thanks for your suggestion :smile:

ocha- commented 11 years ago

@yasulab Do you mind if I translate the rest of this chapter and merge this branch to the master?

yasulab commented 11 years ago

No, because I'm becoming busy, I'm glad if you help translating the rest of this chapter.

@johnnymugs Can you locally type git push origin intro (using your .gitconfig) to update our translation to the latest? It would be helpful for @ocha- to translate the rest of this chapter.

johnnymugs commented 11 years ago

Done! Sorry for the delay, I was out.

yasulab commented 11 years ago

@johnnymugs Thanks! :smile:

yasulab commented 11 years ago

@ocha- This intro branch is now up-to-date. I think it is good timing for us to relay.

ocha- commented 11 years ago

Thanks! Then, I'll take over this branch :+1:

yasulab commented 11 years ago

Super :cool: !! :+1:

ocha- commented 11 years ago

@yasulab I like the favicon you created :) Thank you very much.