Open BuonOmo opened 3 years ago
Hey sorry for the incredible delay. I need to tweak my notification settings a little so I don't miss important contributions on the few open source things I maintain.
I'll have a read through now!
@markburns I'm already glad you answered! I think the PR still needs some love, but it is already more readable than the current version (I'm actually reading it on my fork 😅)
Hi @markburns and thanks for making the book available!
I'm currently going over it to give it a style refresh/fix. This is still a work in progress but I wanted to share already so that if anyone want to discuss my choices it can be done here.
While first reading the repository I also had some troubles guessing which was the correct branch to work on. I've chosen the
master
and I think it should be made default (and maybe renamedmain
).Since I'm reading the book at the same time as I am doing this PR, I may also fix some typos. I'll prefix typo related commits with
typo:
if there are some for one to be able to review those separately.If you do not want to maintain the repository anymore, I'd be glad to help as well 🙂. However, I am French and my English is far from perfect (and I don't know anything about Japanese). Hence my focus being on style and minor typos.
Best, Ulysse
Fixes #47
TODO:
_config.yml
, remove useless configuration.I had a lot of difficulties while reading this great book, and most where related to code blocks being badly formatted. For instance, the
RCLASS(tmp)->iv_tbl
would render asRCLASS->iv_tbl
.Rather than fixing textile which really is not the goto language nowadays. I've made another attempt to switch to markdown (seeing that the former wasn't successful).
I've done that using the script below, and allowing myself a few changes:
figure
html tags, and show captions below,