search

ruby-hacking-guide / ruby-hacking-guide.github.com

Ruby Hacking Guide Translation
http://ruby-hacking-guide.github.io/
318 stars 51 forks source link

Update a few figures to have English translations included #8

Closed nickdesaulniers closed 11 years ago

nickdesaulniers commented 11 years ago

Drew this up quick using skitch. Thoughts?

markburns commented 11 years ago

I think the translations are fine, at a quick glance. I'm not sure about the shadows on the text though.

I also think that rather than 'class of small integers', it should say "Small integer class"

Perhaps it would be a good opportunity to change from jpeg to something like SVG?

ocha- commented 11 years ago

Thank you for creating images :) Creating images in English is a remaining hard work.

Should the other translations in that image also be 'Number class' and 'Integer class' ?

And since we need to create a lot of images, I think it's better a person who create the images can choose the most comfortable way and format.

nickdesaulniers commented 11 years ago

Perhaps it would be a good opportunity to change from jpeg to something like SVG?

SVG would be great, especially to support mobile going forward. While I like skitch because I can whip up figures real quick, it can't export SVG. I've used this tool before for making SVG. If I spent some time with it, it might be more worthwhile to do SVG. Either way, it would be nice to use the same tool for as many images as possible (skitch is very opinionated, but having a whole set of figures from it is nice).

I also think that rather than 'class of small integers', it should say "Small integer class" Should the other translations in that image also be 'Number class' and 'Integer class' ?

Please go through the translations below the figures (like the ones I removed) in the textile files and update them to say what you want, that way I can punch them in real quick and I don't have to redo the images during pull request reviews.

markburns commented 11 years ago

Thanks for this. I'll merge it in and add you to the team as these are certainly better than having the originals. Also noted that we need to add the translations to other figures. SVG is a nice to have. My suggestion about the shadows is also a nice to have, so no huge reason to not include them in, even if it's only short-term.