search

ruby-hyperloop / hyper-mesh

The project has moved to Hyperstack!! - Synchronization of active record models across multiple clients using Pusher, ActionCable, or Polling
https://hyperstack.org/
MIT License
22 stars 12 forks source link

merge access violation errors #75

Closed catmando closed 6 years ago

catmando commented 6 years ago

I see several different error classes across the gems, e.g. Hyperloop::AccessViolation and ReactiveRecord::AccessViolation. It would be useful if they all shared a parent class e.g. HyperloopError rather than inheriting from StandardError.

catmando commented 6 years ago

Thanks ReactiveRecord::AccessViolation was deprecated long ago, but never removed from the code. Taking it out now. Given this I think its okay to continue having the single error Hyperloop::AccessViolation inherit from standard error? If not the issue needs to be on either the Hyperloop-config gem (since its the common base) or on Hyper-operation (since its where it comes from) closing this for now.