ruby-hyperloop / hyper-react

The project has moved to Hyperstack!!
https://hyperstack.org/
MIT License
285 stars 14 forks source link

do booleans work correctly #246

Open catmando opened 6 years ago

catmando commented 6 years ago

Not sure if this was a regression that got fixed or what, but we need to add a test case like this:

it "will preserve boolean values correctly" do    
    stub_const 'Foo', Class.new(React::Component::Base)
    Foo.class_eval do
      param :foo
      def render
        foo = params.foo
        if foo && true
          "fail"
        else
          "succeed"
        end
      end
    end
    expect(Foo).to render_static_html('<span>succeed</span>').with_params(foo: false)
  end
catmando commented 6 years ago
  it "will preserve boolean values correctly" do
    mount 'Foo1', foo1: 'no'
      class Foo1 < React::Component::Base

        param :foo1
        def render
          Foo2(bool: foo1 == 'yes')
        end
      end
      class Foo2 < React::Component::Base
        param :bool
        render { (foo && true) ? 'fail' : 'succeed' }
      end
    end
    expect(page).to contain('succeed')
  end