search

ruby-hyperloop / hyper-react

The project has moved to Hyperstack!!
https://hyperstack.org/
MIT License
285 stars 14 forks source link

remove dependency on ERB #255

Closed catmando closed 6 years ago

catmando commented 6 years ago

React::Config.config[:environment] is set in react/config/client.rb.erb

This passes on rails env to client.

This should be responsibility of hyper-config, and should not use ERB.

Looks like is only used in one place: in IsomorphicHelpers in the self.log method to turn off warnings in and info in production.

catmando commented 6 years ago

Moved (and deprecated) the whole environment thing. https://github.com/ruby-hyperloop/hyperloop-config/issues/14