ruby-hyperloop / hyper-react

The project has moved to Hyperstack!!
https://hyperstack.org/
MIT License
285 stars 14 forks source link

event `onChange` does not map to `on_change` when attaching to ruby component #259

Open catmando opened 6 years ago

catmando commented 6 years ago

if you say for example: MyRubyComponent().on(:change) then MyRubyComponent will receive a onChange param. But if you say MyRubyComponent().on(:foo_bar) then MyRubyComponent will receive a on_foo_bar param.

See https://github.com/ruby-hyperloop/hyper-react/blob/dc90b8444f5a64831e6d9f21c280b0b7afab8b34/lib/react/element.rb#L122

For why.

The reason this is done is that MyRubyComponent can pass all_other_params on to components nested within it, and the event names will follow along.

Perhaps rethinking the entire param interface between ruby and native components could yield a more consistent solution.