ruby-hyperloop / hyper-react

The project has moved to Hyperstack!!
https://hyperstack.org/
MIT License
285 stars 14 forks source link

all_other_params is only evaluated on first mount #267

Open catmando opened 6 years ago

catmando commented 6 years ago
class Foo < Hyperloop::Component
  collect_all_other_params_as :opts
  ...
end
...
class Test < Hyperloop::Component
  after_mount do 
    every(1) { force_update! }
  end
  render do
    Foo(time: Time.now)
  end
end

The value of params.opts[:time] will never change.

The problem is that the collected props are kept in an instance variable that needs to be reset when new props arrive.