search

ruby-i18n / i18n

Internationalization (i18n) library for Ruby
MIT License
977 stars 408 forks source link

Remove pry from Gemfile as it is not used #608

Closed dvzrv closed 2 years ago

dvzrv commented 2 years ago

Gemfile: The pry gem is installed but does not seem to be used for anything. Tests pass without it just fine.

Fixes #607

radar commented 2 years ago

It's used when I debug stuff.

dvzrv commented 2 years ago

It's used when I debug stuff.

I understand that, but having it in the general Gemfile, which is used e.g. by downstream distributions implies that it is used (and required) during testing.

Adding this package to the Gemfile means that downstream distributions (when not investigating whether pry is used in the remaining codebase or not) are required to package pry and its entire dependency tree (e.g. coderay and all of its dependencies).

This is significantly more work than just not adding pry to the Gemfile, especially given that you can install pry separately if I'm not mistaken.

From a distributor perspective: I would like to be able to run tests. If I have to package 10 more packages (that are actually not required) it is more likely that I will not run tests (which is rather to the detriment of i18n users in general and distribution users in particular).

Is there a way for you to install the pry gem on the side, so that it is not required in the Gemfile? Alternatively, can there be a comment in the Gemfile that clarifies that this gem is actually not required to run tests?

radar commented 2 years ago

You make a fine point. Let's remove it.